alamb commented on code in PR #24068:
URL: https://github.com/apache/datafusion/pull/24068#discussion_r3731887672
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1087,6 +1087,10 @@ impl AggregateExec {
}
/// Returns the dynamic filter expression for this aggregate, if set.
+ #[deprecated(
+ since = "55.0.0",
+ note = "Use ExecutionPlan::dynamic_expressions_produced instead"
Review Comment:
👍
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1945,6 +1964,16 @@ impl ExecutionPlan for AggregateExec {
vec![&self.input]
}
+ fn dynamic_expressions_produced(&self) -> Vec<Arc<dyn PhysicalExpr>> {
Review Comment:
Could this ever return something other than `DynamicFilterPhysicalExpr`?
Specifically I am wonering if this should be
```rust
fn dynamic_expressions_produced(&self) -> Vec<Arc<dyn
DynamicFilterPhysicalExpr>> {
```
instead of
```rust
fn dynamic_expressions_produced(&self) -> Vec<Arc<dyn PhysicalExpr>> {
```
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
