milenkovicm commented on code in PR #2202:
URL:
https://github.com/apache/datafusion-ballista/pull/2202#discussion_r3737946864
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -575,7 +575,12 @@ impl ShuffleWriterExec {
compression_type,
)
.await
- .map_err(|e|
DataFusionError::Execution(format!("{e:?}")))?;
+ .map_err(|e| {
+ DataFusionError::ArrowError(
Review Comment:
why dont we use `DataFusionError::External` ?
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -650,6 +661,5 @@ impl AdaptivePlanner {
/// Wraps stage plan with addition of references to previous stages
pub(crate) struct AdaptiveStageInfo {
pub(crate) plan: Arc<dyn ShuffleWriter>,
- #[allow(dead_code)] // TODO: still not sure if this is needed
Review Comment:
i like to call myself API visionist I had a hunch it'll be needed in the
future 😀
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -3227,6 +3218,25 @@ mod test {
// todo!()
// }
+ fn wrapped_fetch_failed_task(
+ executor_id: &str,
+ map_stage_id: usize,
+ map_partition_id: usize,
+ ) -> FailedTask {
+ let err =
BallistaError::DataFusionError(Box::new(DataFusionError::ArrowError(
Review Comment:
same question here, cant we use DFE::External
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
