villebro commented on code in PR #2202:
URL:
https://github.com/apache/datafusion-ballista/pull/2202#discussion_r3738753849
##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -575,7 +575,12 @@ impl ShuffleWriterExec {
compression_type,
)
.await
- .map_err(|e|
DataFusionError::Execution(format!("{e:?}")))?;
+ .map_err(|e| {
+ DataFusionError::ArrowError(
Review Comment:
Good point. I agree it would be a cleaner/shorter wrapper shape, but
switching to it here would require adding an explicit downcast/unwrapping path
and corresponding tests, which would probably increase the complexity of this
PR. I think it could be an excellent follow-up PR focused specifically on
harmonizing these error paths, and one I can take on after this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
