Smallfu666 commented on PR #5280: URL: https://github.com/apache/datafusion-comet/pull/5280#issuecomment-5237149069
I was looking at this while working on the `Abs` side of #5071, so this may already be on your radar. `ansi_arithmetic_kernel` maps every non-`DivideByZero` error to `from_type: "integer"`, so Int64 overflow still comes out as `integer overflow` instead of Spark's `long overflow`. `test_ansi_int64_overflow` only checks `is_err()`, so it stays green either way. Might be simpler to handle here than as a follow-up, but either way works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
