dwsmith1983 commented on code in PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r3920759711
########## contrib/delta-spark/src/test/scala/org/apache/comet/contrib/delta/JvmLowercaseParitySuite.scala: ########## @@ -0,0 +1,343 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.contrib.delta + +import java.util.Locale + +import org.scalatest.funsuite.AnyFunSuite + +import org.apache.comet.serde.operator.JvmCaseTables + +/** + * Self-validating proof that `JvmCaseTables.mirrorLowercase` -- a line-for-line mirror of the + * native `JvmCaseTables::lowercase` in `native/core/src/parquet/schema_adapter.rs`, run over the + * tables `JvmCaseTables` generates from the RUNNING JVM -- reproduces this JVM's + * `String.toLowerCase(Locale.ROOT)`. Because both the tables and the expectations come from the + * same running JVM, this suite passes on ANY supported JDK by construction. + * + * Needs no `SparkSession`, so it extends `AnyFunSuite` directly rather than `CometDeltaTestBase`. + */ +class JvmLowercaseParitySuite extends AnyFunSuite { Review Comment: The parity suite is deleted along with the Scala mirror it tested. Main's folding calls the JVM directly through JNI, so there is no second implementation left to drift; #5602 ships its own coverage in CometNativeReaderSuite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
