dwsmith1983 commented on PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#issuecomment-5523616898
One correction on the default cargo feature, since it has now come up twice: this was proposed and accepted earlier in this thread (Aug 19), and sunchao clarified on Aug 27 that the adjacent contrib-delta comment means zero kernel surface, not zero Delta surface, so the two features are not in conflict. The cost is about 82 KB in the dylib and the code is unreachable without the contrib jar plus the config. I have added a cross-reference to that decision in the Cargo.toml comment and reworded the contrib-delta one to say delta-kernel explicitly (70c5be8b4) so it does not need re-litigating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
