dwsmith1983 commented on PR #5872: URL: https://github.com/apache/datafusion-comet/pull/5872#issuecomment-5678175798
> Please retain path-style addressing for dotted HTTPS buckets, including when no custom endpoint is configured, and add assertions on the resulting request URL. Done. A bucket whose name contains a dot is addressed path-style whenever the endpoint is HTTPS, which covers the default AWS endpoint and a custom `https://` one; over `http://` it stays virtual-hosted, as the SDK does. The tests assert the endpoint and flag pair object_store receives for the default endpoint, an explicit HTTPS endpoint, an HTTP endpoint, and a plain bucket as the control. The addressing paragraph in `datasources.md` says the same. Apologies for the delay, this note and your earlier ones slipped past my sweep. > Please retain the Hadoop/SDK provider distinction and select a credentials-only default for the Hadoop spelling, while preserving normal SDK defaults for the SDK spellings. Done. The profile metadata carries whether the provider is credentials-only; Hadoop's spelling is, the SDK spellings are not. With no file override, Hadoop's spelling now reads `AWS_SHARED_CREDENTIALS_FILE` or `~/.aws/credentials` as a credentials-format file and nothing else, so a same-name role profile in the config file never applies; the SDK spellings keep the SDK defaults. A test covers the selected file with and without the override. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
