andygrove commented on PR #4821: URL: https://github.com/apache/datafusion-comet/pull/4821#issuecomment-5719750440
Triage note for anyone picking this up: #4997 implements `getHoursOfTime`, `getMinutesOfTime`, `getSecondsOfTime` and `getSecondsOfTimeWithFraction` natively, adding a `StaticInvoke` arm to the same `sparkVersionSpecificExprToProtoInternal` in the same `spark-4.1+/CometExprShim.scala` that this PR routes through the codegen dispatcher. They conflict directly on those four expressions. The dispatcher was the cheap way to get the whole Spark 4.1 TIME family off Spark fallback in one go, not the end state, so I would rather the native extractions in #4997 take precedence and this PR shrink to `TimeAddInterval`, `SubtractTimes`, `TimeDiff` and `TimeTrunc` plus the `TimeNanoVector` plumbing and the cast wiring. @YutaLin, does that split work for you? #4951 sits alongside either version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
