andygrove commented on PR #4997: URL: https://github.com/apache/datafusion-comet/pull/4997#issuecomment-5719751078
Triage note: this and my #4821 both add a `StaticInvoke` arm for `getHoursOfTime`, `getMinutesOfTime`, `getSecondsOfTime` and `getSecondsOfTimeWithFraction` to `sparkVersionSpecificExprToProtoInternal` in the same `spark-4.1+/CometExprShim.scala`, so they conflict on exactly those four expressions. Mine routes them through the JVM codegen dispatcher, which was only ever meant to get the whole Spark 4.1 TIME family off Spark fallback quickly — a native implementation is the better end state. I would rather this one land and shrink #4821 to the expressions it does not cover (`TimeAddInterval`, `SubtractTimes`, `TimeDiff`, `TimeTrunc`) plus the vector plumbing. Does that work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
