andygrove commented on PR #5786: URL: https://github.com/apache/datafusion-comet/pull/5786#issuecomment-5719755275
Triage note: the "Spark-compatible duplicate-name resolution" you name as separate work is already open as #5654. It makes case-sensitive duplicate names resolve last-wins like Spark's `.toMap`, raises Spark's duplicate error in field-id lookup mode, and tightens `remap_physical_schema`. You share `parquet_exec.rs`, `schema_adapter.rs` and `eager_page_index_reader_factory.rs`. Since one PR rejects reads and the other resolves them, it matters which cases each of you is claiming — there is at least one shape, case-sensitive duplicate top-level names, where rejecting here would pre-empt resolving there. Could you and @dwsmith1983 agree the split and the landing order? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
