andygrove commented on PR #6000: URL: https://github.com/apache/datafusion-comet/pull/6000#issuecomment-5721956392
@comphead added one in bacd419, at the top of the "Three tiers" section so it sets up the table rather than repeating it. It shows the four events down the left, the tier each one runs, and the label opt-in as dotted edges, including Spark 3.4 sitting on its own with nothing but a label pointing at it. One thing I would like your read on before this goes in. Our site is Sphinx, and a plain ```mermaid fence renders there as a literal code block, so making the diagram actually draw meant adding `sphinxcontrib-mermaid` to `docs/requirements.txt` and `myst_fence_as_directive` to `conf.py`. That builds clean locally and the fence comes out as a mermaid element rather than a highlighted block, but the `docs` job is push-only, so nothing on this PR exercises it — it would first run after merge. The part I am less sure about is that the extension draws the diagram in the browser and pulls mermaid.js from cdn.jsdelivr.net, which as far as I can tell would be the first third-party asset the Comet site loads. I do not think that is a problem, but it is a change in kind rather than degree for an ASF site, so I would rather you agreed than assume. If you would rather not take it on, I am happy to drop the diagram and keep this documentation-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
