andygrove commented on PR #6000: URL: https://github.com/apache/datafusion-comet/pull/6000#issuecomment-5722121196
Correcting myself on the comment above: I built the site locally to look at the diagram and found that jsdelivr would not be the first third-party asset the Comet site loads. `docs/source/conf.py` already pulls `buttons.github.io/buttons.js`, and `docs/source/_templates/layout.html` pulls Inter and JetBrains Mono from `fonts.googleapis.com` and `fonts.gstatic.com`. Both are ours, not the theme's. So this is a fourth external host rather than a change in kind, which makes the concern I raised weaker than I put it. Still worth you nodding at, but it is not the precedent I implied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
