dwsmith1983 commented on code in PR #6116:
URL: https://github.com/apache/datafusion-comet/pull/6116#discussion_r4078303284
##########
native/core/src/execution/operators/iceberg_scan.rs:
##########
@@ -230,7 +230,13 @@ impl IcebergScanExec {
let scan_metrics = scan_result.metrics().clone();
let stream = scan_result.stream();
- let spark_options = SparkParquetOptions::new(EvalMode::Legacy, "UTC",
false);
+ let mut spark_options = SparkParquetOptions::new(EvalMode::Legacy,
"UTC", false);
+ // Iceberg resolves columns by id itself and its reader supplies the
ids, so the
+ // missing-id check that guards plain Parquet reads does not apply
here. The same holds
+ // for a migrated table read through a name mapping: the reader still
resolves the
+ // columns itself and hands back a schema of its own, so the Spark
check has nothing to
+ // say there either.
+ spark_options.ignore_missing_field_id = true;
Review Comment:
> Worth either dropping it then or reworking the comment so it does not read
as load-bearing when it is not.
Dropped in ba0d8d7c2. The Iceberg path builds its options with `new`, where
the flag is false, and nothing on that path sets it, so the check stays inert
there without the extra line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
