dwsmith1983 commented on code in PR #6116:
URL: https://github.com/apache/datafusion-comet/pull/6116#discussion_r4100362578
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -194,7 +199,11 @@ pub(crate) fn init_datasource_exec(
scan_io_source,
parquet_source.metrics(),
)
- .with_spark_variant_schema(projects_variant),
+ .with_spark_variant_schema(projects_variant)
+ .with_missing_field_id_check(
+ spark_parquet_options.requested_schema_has_field_ids,
+ spark_parquet_options.ignore_missing_field_id,
+ ),
Review Comment:
Both options fields are gone. `init_datasource_exec` takes one
`require_field_ids: bool` in the old parameter's position and hands it to the
factory through `with_require_field_ids`. The factory and the reader each store
that one bool, and `SparkParquetOptions` no longer carries
`ignore_missing_field_id` either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
