pepijnve commented on code in PR #25412:
URL: https://github.com/apache/datafusion/pull/25412#discussion_r4098696313
##########
datafusion/optimizer/src/extract_leaf_expressions.rs:
##########
@@ -637,6 +637,19 @@ impl<'a> LeafExpressionExtractor<'a> {
}
}
+/// The way `schema` names `col`, or `None` when `schema` does not hold it
Review Comment:
nit: this sentence took me a couple of tries to grok. The function has an
active name (an action), but the first sentence is describing a noun (a
property). Might be better to write this in a 'Does computation xyz' style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
