pepijnve commented on code in PR #25412:
URL: https://github.com/apache/datafusion/pull/25412#discussion_r4098705235
##########
datafusion/optimizer/src/extract_leaf_expressions.rs:
##########
@@ -702,27 +715,27 @@ fn build_extraction_projection_impl(
// than target_schema (the projection's output) because columns
produced
// by alias expressions (e.g., CSE's __common_expr_N) exist in the
output but
// not the input, and cannot be added as pass-through Column
references.
+ //
+ // Compare both sides in the input's spelling (see `resolve_against`).
Review Comment:
What are the 'sides' being referred to here? In the final sentence there's a
reference to an empty union side. Makes this hard to interpret.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
