Visorgood commented on PR #6110: URL: https://github.com/apache/datafusion-comet/pull/6110#issuecomment-5834883380
Thanks for the thorough pass – especially for checking the hash projections and the range sampling/comparator setup against 3.4.3, 3.5.9, 4.0.4, 4.1.3 and 4.2.0. Cross-version behaviour was the one part I could only reason about rather than test. Agreed on the CI point. The head has only the label check; Comet CI and CodeQL are both action_required. @andygrove added run-spark-4.1-tests, but the workflows still need someone to approve them before anything runs. Could one of you kick them off? Everything I ran locally is listed in the description, and I'm happy to re-run or extend it once CI produces a verdict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
