Visorgood commented on PR #6110:
URL:
https://github.com/apache/datafusion-comet/pull/6110#issuecomment-5843797289
Merged main to resolve the conflict. It was in the `CometColumnarExchange`
paragraph of understanding-comet-plans.md: the 1.1.0 docs update (#6168) had
already dropped collated strings as the example and added that collated keys
use Spark's shuffle. I kept that wording and only added the case this PR
introduces – native shuffle declining a key expression it cannot serialize,
with the `mapsort` wrapper as the example.
Re-ran everything after the merge and a native rebuild:
CometShuffleSuite, DisableAQECometShuffleSuite, CometShuffleManagerSuite,
CometCollationSuite, CometTPCDSV1_4/V2_7_PlanStabilitySuite
Suites: completed 6, aborted 0
Tests: succeeded 256, failed 0
Plan-stability goldens are still unchanged.
The workflows are still awaiting approval, so there's no exact-head CI
verdict yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
