andygrove commented on PR #5505: URL: https://github.com/apache/datafusion-comet/pull/5505#issuecomment-5848814717
The automated review above says the compile concern wasn't substantiated, but my earlier comment was about current main rather than this branch's base. #5494 removed `handle_task_shared_pool_release`, and this branch still calls it in `releasePlan`, so it still conflicts in `jni_api.rs` and won't build once merged. Could you merge main? The question about logging the timeout at `debug!` rather than `warn!` is still open too. I'll take another look after the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
