andygrove commented on PR #5932:
URL:
https://github.com/apache/datafusion-comet/pull/5932#issuecomment-5892104227
`dev/diffs/4.2.0.diff` landed on main in #4950. It has the same
`IgnoreComet("https://github.com/apache/datafusion-comet/issues/5741";)` on
"variant logical type annotation - ignore variant annotation" that this PR
removes from the 4.1 diff. Since this PR closes #5741, could you remove it from
the 4.2 diff too? Otherwise the Spark 4.2 suite will keep skipping that test
after the fix lands. The [Spark SQL Tests
guide](https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html)
covers regenerating a diff.
I've added the `run-spark-4.2-tests` label so CI runs the Spark 4.2 SQL
suite on this PR. The first run will fail in "Pre-compile Spark Test classes",
because main's 4.2 diff still asks for Comet `1.1.0-SNAPSHOT` (#6380). #6398
fixes that. Once it lands, merging main into this branch will rerun the suite
and give a real result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
