parthchandra commented on PR #6456: URL: https://github.com/apache/datafusion-comet/pull/6456#issuecomment-5919288835
The `iceberg_div_floor` math faithfully reproduces iceberg-java's `DateTimeUtil.convertMicros` pre-epoch rounding (the `+1` correction failing to carry at microsecond-of-second 999999), all four transforms and both timestamp types are covered, and there's no overflow risk. One check: - **`docs/source/contributor-guide/iceberg-writes.md:223`** — please double-check this accepted-divergence paragraph (the #6426 pre-1970 floor note) doesn't still describe pre-epoch rounding as an open gap now that this PR fixes it. If it does, it should be updated or removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
