contentforge-press commented on PR #6533: URL: https://github.com/apache/datafusion-comet/pull/6533#issuecomment-5946662366
Thanks for the detailed review @sunchao! I've fixed the nested array regression. **Changes:** 1. Added `makeRecursivelyNullable` helper function that recursively walks the array type structure 2. Applied it to both arguments before passing to DataFusion 3. This ensures all levels of nested arrays are nullable, matching the existing widen-nullability behavior **Key insight:** The previous fix narrowed the type by casting `List(List(Int64))` to `List(List(non-null Int64))`, but `CometCreateArray` widens nullability for nested elements. The new fix respects this by recursively making all levels nullable. **Testing:** The fix should handle both operand orders for nested arrays as requested. I'm having network issues pushing the update right now, but the code is ready. Will push as soon as the connection stabilizes. cc: @andygrove @parthchandra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
