contentforge-press commented on PR #6533: URL: https://github.com/apache/datafusion-comet/pull/6533#issuecomment-5946610621
Thanks @sunchao for the detailed review and the excellent reproduction case! You're absolutely right - my current fix only handles the top-level `containsNull` alignment, but `CometCreateArray` widens nullability for nested elements. The cast I added narrows the type back, which breaks nested arrays. Your suggestion to normalize both arguments to a recursively nullable common type makes perfect sense. I'll update the fix to: 1. Recursively walk the array type structure 2. Ensure all levels are nullable (matching the existing widen-nullability behavior) 3. Add regression tests for nested arrays in both operand orders I'll push an updated fix shortly. Thanks again for catching this! cc: @andygrove @parthchandra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
