2010YOUY01 commented on code in PR #25963:
URL: https://github.com/apache/datafusion/pull/25963#discussion_r4164812156
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1408,6 +1408,13 @@ impl HashJoinExec {
/// physical optimizer rule to determine a good join order, which is
/// executed before the `EnforceDistribution` rule (the rule that may
/// insert `RepartitionExec` operators).
+ ///
+ /// # Public Only for Internal Use:
+ ///
+ /// This is not a public API and is for internal use only; see [API
policy] for details.
+ ///
+ /// [API policy]:
https://datafusion.apache.org/contributor-guide/api-health.html#internal-public-apis
+ #[doc(hidden)]
Review Comment:
This API seem like reasonable to be public, however now it requires
cooperation from several other optimizer rules, to make it safe. The comments
right above can demonstrate it is tricky to use.
Note downstreams can still have access to it, this marker is only a hint for
(a) might change without often (b) tricky to use it correctly, as explained in
the link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
