github-actions[bot] commented on PR #25318: URL: https://github.com/apache/datafusion/pull/25318#issuecomment-5957349600
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.1.0 (current) Built [ 33.206s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.081s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 28.966s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.082s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.444s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/auto_trait_impl_removed.ron Failed in: type ScalarSubqueryResults is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/physical_planning_context.rs:160 type ScalarSubqueryResults is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/physical_planning_context.rs:160 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 65.046s] datafusion-expr Building datafusion-ffi v55.1.0 (current) Built [ 52.247s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.058s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 52.647s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.059s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.246s] 223 checks: 222 pass, 0 fail, 1 warn, 31 skip --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_PhysicalExtensionCodec.clone moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/physical_extension_codec.rs:111 FFI_PhysicalExtensionCodec.release moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/physical_extension_codec.rs:114 FFI_PhysicalExtensionCodec.version moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/physical_extension_codec.rs:117 FFI_PhysicalExtensionCodec.private_data moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/physical_extension_codec.rs:121 FFI_PhysicalExtensionCodec.library_marker_id moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/proto/physical_extension_codec.rs:125 Summary no semver update required Warning produced 1 major and 0 minor level warnings produced warnings suggest new major version Finished [ 106.850s] datafusion-ffi Building datafusion-proto v55.1.0 (current) Built [ 48.718s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 48.837s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.113s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 98.993s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
