sam-1112 commented on PR #5956: URL: https://github.com/apache/datafusion-comet/pull/5956#issuecomment-6007341892
Thanks, @andygrove. Extreme UTC/NTZ coarse truncation now uses integer calendar arithmetic, so truncating `Long.MaxValue` to YEAR returns `+294247-01-01`, while unrepresentable coarse results raise an overflow error. The SQL regression tests `date_trunc` directly with `expect_native(date_trunc)` and compares against Spark, and the NULL validity checks remain intact. I also fixed errors from unused dictionary entries and made fine-grained truncation handle NULL slots and lower-bound overflow consistently with Spark. Rust coverage includes adjacent maximum values and negative extremes. Injecting epoch zero for the extreme result makes the new SQL regression fail; this mutation check did not restore the old NULL merge implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
