sam-1112 commented on PR #5956: URL: https://github.com/apache/datafusion-comet/pull/5956#issuecomment-6008120492
Thanks, @andygrove. The regression now projects `date_trunc` directly under `expect_native(date_trunc)` and compares the exact results with Spark, removing the `unix_micros` wrapper. Extreme UTC/NTZ coarse truncation now uses integer calendar arithmetic, so `Long.MaxValue` truncated to YEAR returns `+294247-01-01`; unrepresentable results raise an overflow error, and the NULL merge checks remain intact. I also fixed fine-unit lower-bound arithmetic and dictionary handling so unused overflowing values do not fail a query, while safe low-cardinality dictionaries avoid scanning all keys. Rust coverage includes adjacent maximum values, negative extremes, poisoned NULL slots, and dictionary cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
