asolimando commented on PR #26094: URL: https://github.com/apache/datafusion/pull/26094#issuecomment-6031275365
Thanks @zhuqi-lucas! My understanding of the benchmark run: - `physical_plan_tpcds_all`: 626.1 ms -> 600.9 ms (-4.0%) - `physical_plan_tpch_all`: 41.4 ms -> 40.4 ms (-2.4%), and every TPC-H query is faster (-1% to -7%) - ClickBench (single table, no joins) is within noise The +5% on `physical_select_all_from_1000` also appears in `logical_select_all_from_1000` and `optimizer_select_all_from_1000`, which only run logical planning, so it is not related to this change. The gain is little smaller than the sf1 numbers I had locally (6%, as reported in the description) because the benchmark tables are empty, so each statistics computation is cheap. If you think this is interesting I can do another self-review pass on the PR and remove it from draft, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
