asolimando commented on PR #26094: URL: https://github.com/apache/datafusion/pull/26094#issuecomment-6038543331
@zhuqi-lucas thanks a lot for your feedback, after self-review I have pushed some test refactoring, doc improvements and improved API ergonomics (added `PhysicalOptimizerContext::compute_statistics` for custom physical rules), nothing affecting the benchmark (in principle), the PR is now reviewable if you have bandwidth! I noticed the coverage warning, I could fix that easily but I don't see anything that genuinely needs more coverage, happy to add more tests if you see fit. OT: is there a process to get into the allow-list to run benchmarks? What are the criteria for eligibility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
