ByteBaker commented on issue #23322: URL: https://github.com/apache/datafusion/issues/23322#issuecomment-6317043823
@haochunchang first of all, thank you for contributing, and apologies for the delay in getting back to review this. I managed to go through the code. Fair disclosure, I'm not a datafusion maintainer. So I'll only comment to the merits of the diff. The API itself, or the context specific to the datafusion would determine what parts would actually pass through. For that @comphead and @alamb can help. I've added 3 comments on your PR. Additionally, my nit is that the PR description is a little too dense (having been generated by claude) which makes it quite hard for a human reviewer. Request you to also simplify the same. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
