Kristofferjoha commented on code in PR #26669:
URL: https://github.com/apache/datafusion/pull/26669#discussion_r4367230779
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -566,11 +566,17 @@ impl HashJoinExecBuilder {
}
/// Reset task-local runtime state while retaining the immutable prepared
build.
- pub fn reset_state(mut self) -> Self {
+ pub fn reset_state(mut self) -> Result<Self> {
Review Comment:
Thanks, `reset()` made infallible and kept
`HashJoinExecBuilder::reset_state()` returning Self. Callers updated and CTE
regression and tests passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
