github-actions[bot] commented on PR #26669: URL: https://github.com/apache/datafusion/pull/26669#issuecomment-6395905685
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning e3fe60c8b3326849cacd97499f2ba0971cc70d07 Building datafusion-physical-expr v55.1.0 (current) Built [ 26.679s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.039s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 5.376s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.248s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure inherent_method_now_returns_unit: inherent method now returns unit --- Description: A publicly-visible method that used to return a value now returns `()`. impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/inherent_method_now_returns_unit.ron Failed in: datafusion_physical_expr::expressions::DynamicFilterPhysicalExpr::reset in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:349 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 33.594s] datafusion-physical-expr Building datafusion-physical-plan v55.1.0 (current) Built [ 19.400s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.161s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 8.603s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.160s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.509s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 29.988s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
