github-actions[bot] commented on PR #26746: URL: https://github.com/apache/datafusion/pull/26746#issuecomment-6398923306
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 36f393559620235c250f68727e3243cc7f429db8 Building datafusion-expr v55.1.0 (current) Built [ 35.529s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.108s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 7.839s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.111s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.608s] 229 checks: 227 pass, 2 fail, 0 warn, 31 skip --- failure trait_method_marked_deprecated: trait method #[deprecated] added --- Description: A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_marked_deprecated.ron Failed in: method is_nullable in trait datafusion_expr::AggregateUDFImpl in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:461 --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_expr::AggregateUDF::is_nullable in /home/runner/work/datafusion/datafusion/datafusion/expr/src/udaf.rs:212 Summary semver requires new minor version: 0 major and 2 minor checks failed Finished [ 46.585s] datafusion-expr Building datafusion-ffi v55.1.0 (current) Built [ 50.865s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.073s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 22.027s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.072s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.276s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 74.870s] datafusion-ffi Building datafusion-functions-aggregate v55.1.0 (current) Built [ 11.675s] (current) Parsing datafusion-functions-aggregate v55.1.0 (current) Parsed [ 0.057s] (current) Building datafusion-functions-aggregate v55.1.0 (baseline) Built [ 8.118s] (baseline) Parsing datafusion-functions-aggregate v55.1.0 (baseline) Parsed [ 0.059s] (baseline) Checking datafusion-functions-aggregate v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.189s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 21.168s] datafusion-functions-aggregate Building datafusion-physical-expr v55.1.0 (current) Built [ 3.791s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.058s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 3.906s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.060s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.343s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 9.516s] datafusion-physical-expr ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
