CuteChuanChuan commented on code in PR #26746:
URL: https://github.com/apache/datafusion/pull/26746#discussion_r4423003852
##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -301,7 +301,7 @@ impl AggregateExprBuilder {
if let Some(output_metadata) = output_metadata {
return_field = output_metadata.add_to_field_ref(return_field);
}
- let is_nullable = fun.is_nullable();
+ let is_nullable = return_field.is_nullable();
Review Comment:
Done in d95f1374, thanks for the suggestion!
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -293,8 +293,8 @@ impl AggregateUDFImpl for Count {
Ok(DataType::Int64)
}
- fn is_nullable(&self) -> bool {
- false
+ fn return_field(&self, _arg_fields: &[FieldRef]) -> Result<FieldRef> {
Review Comment:
Addressed in d95f1374.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
