alamb commented on issue #26481: URL: https://github.com/apache/datafusion/issues/26481#issuecomment-6425468389
> RE above proposal to move rules like WindowTopN and JoinSelection: is it possible we limit this discussion thread's scope to "keep existing order, but split to analyzer/optimizer"? And all other refactors should be discussed separately/one-by-one I agree > I'd like to try a PoC of what the end state would look like first. With the https://github.com/apache/datafusion/pull/26757, the analyzer phase is mostly a wrapper around the existing optimizer rules: every built-in rule is still a PhysicalOptimizerRule and runs in the analyzer through RunInAnalyzer. Apart from OutputRequirements and EnsureRequirements, the rules before enforcement are performance rules that happen to need to run early, so it isn't really an analyzer yet. The current design works, but I'm worried we'd need to change it again later, which could easily turn into another breaking change. I'd like to avoid that. A PoC sounds good, but I am not sur I will be able to review a really large POC PR -- so if you make one and want feedback, perhaps you can point us at the specific parts that you would like reviews on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
