dwsmith1983 commented on code in PR #7127:
URL: https://github.com/apache/datafusion-comet/pull/7127#discussion_r4383867930
##########
spark/src/main/scala/org/apache/comet/objectstore/AbfsAuthResolver.scala:
##########
@@ -208,7 +208,7 @@ private[comet] object AbfsAuthResolver extends Logging {
hadoopConf: Configuration,
uri: URI,
handles: Try[Handles]): Outcome = {
- val secrets = ArrayBuffer[String]()
+ val secrets = ArrayBuffer[String](uriSecrets(uri): _*)
Review Comment:
`redact` now finds every secret in the same text and masks the union of the
spans, so the order of `secrets` no longer matters. Overlapping or adjacent
matches collapse into one `<redacted>`. The quoted `key ="..."` pass still runs
first and the minimum length is unchanged.
The new resolver case puts `client-secret` in the URI password and
`oauth-client-secret-4f9a2c` in the auth type and client secret, and checks
that no piece of the credential is left in the forwarded message. A `redact`
case covers containment, partial overlap, adjacency and a secret that overlaps
itself, each with the secrets in both orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
