sunchao commented on code in PR #7258:
URL: https://github.com/apache/datafusion-comet/pull/7258#discussion_r4406377601
##########
spark/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:
##########
@@ -258,11 +258,21 @@ object Utils extends CometTypeShim with Logging {
val dictionaryProvider: CDataDictionaryProvider = new
CDataDictionaryProvider
val codec = CompressionCodec.createCodec(SparkEnv.get.conf)
Review Comment:
Included this in the separate serializer PR #7310: one lazy codec per
serializer iterator, with a fresh compressed output stream per batch. Lazy
initialization also preserves empty/unconsumed-iterator behavior. I am
refreshing the measurements with that serializer as the batching baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
