sunchao commented on PR #7258: URL: https://github.com/apache/datafusion-comet/pull/7258#issuecomment-6481892101
@comphead, the simplification pass is addressed in `48e1024bfc`. The inline replies cover the shared JNI buffer validation, centralized row check, direct constructor setup, shared fixtures/benchmark helpers, and consolidated tests. I also removed the forwarding-only RDD test and the duplicated/reflowed documentation from the review body. I kept conservative bitmap padding for the output-copy bound and explained the aliased-Boolean case in that thread, which remains open for discussion. The other addressed threads are resolved. Validation passed 15 focused Rust tests and 168 JVM tests across both changes (six existing version-gated cancellations), plus strict Spark 3.5/Delta compilation and formatting/config checks. Five independent source-review passes have no remaining actionable P1/P2 findings. One benchmark initialization issue found during review was fixed before any timings were taken; mode selection now lives in the inert base companion. Both PR descriptions now contain fresh measurements. The wide-string control is slower with native batching, and the complete-query results are order-sensitive, so those limitations are explicit and the flag remains default-off. Hosted CI is still separate from the local validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
