villebro commented on code in PR #2797:
URL:
https://github.com/apache/datafusion-ballista/pull/2797#discussion_r4503043310
##########
ballista/executor/src/config.rs:
##########
@@ -226,12 +226,13 @@ pub struct Config {
)]
pub memory_pool_fraction: f64,
/// Maximum disk space spill files may use, per session runtime (shared by
- /// that session's tasks). When unset, DataFusion's default (100 GB)
- /// applies. Accepts the same values as `--memory-pool-size`.
+ /// that session's tasks). When unset, the space free on the work dir's
+ /// filesystem at startup, or DataFusion's default (100 GB) if that is
+ /// smaller. Accepts the same values as `--memory-pool-size`.
Review Comment:
This was slightly difficult to parse. Maybe we could reword this to
something more readable, like
> When unset, defaults to the smaller of the work-dir filesystem’s free
space at startup and DataFusion’s 100 GB default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
