andygrove commented on PR #2797: URL: https://github.com/apache/datafusion-ballista/pull/2797#issuecomment-6727526525
@villebro I think the old wording made this read backwards, sorry about that! With 1 TB free on the work dir at startup, the limit is about 1 TB, so the scenario you describe (failing at 100 GB despite the free space) is what this PR fixes. A live check is doable since DataFusion's `DiskManager::set_max_temp_directory_size` takes `&self`. But the executor would need to track every live session runtime and refresh them on a timer. The right value would also be "used + currently free", not just "currently free", or a query's own spills would shrink its limit under it. I'd rather keep this PR to the startup snapshot and do the live version as a follow-up, so I opened #2820 for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
