lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4489839572
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -160,6 +160,31 @@ fn criterion_benchmark(c: &mut Criterion) {
do_hash_test(b, &arrays);
});
}
+ // Apply additional null-density cases to all Int32 dictionary
+ // benchmarks, including any added in the future.
+ if let Some(dict) =
array.as_any().downcast_ref::<DictionaryArray<Int32Type>>() {
Review Comment:
i've removed the downcast and added `additional_null_densities` to
`BenchData`. only the int32 dictionary case has `[50, 97]` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
