lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4502609567
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -30,6 +30,9 @@ struct BenchData {
array: ArrayRef,
/// Union arrays can't have null bitmasks added
supports_nulls: bool,
+ /// Extra null percentages to benchmark, in addition to the default 3%
+ /// ("nulls") case
+ additional_null_densities: &'static [u8],
Review Comment:
agreed, i've replaced `supports_nulls` and `additional_null_densities` with
a single `null_densities` field. an empty list means no null cases are
registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
