andygrove commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6744926895
> Could you please provide links to your version and benchmarks over a corpus like the one I prepared in https://github.com/LucaCappelletti94/sql_ast_benchmark ? I'm still working towards 100% support for all the features of v1 and full parity with the test corpus. I also wanted to gauge interest in a rewrite first, before sharing the implementation. > My focus at this time is to work further towards completing the AST support and resolving the many fuzzer-identified bugs, which would confound the bugs caused from any refactoring. The library still lacks a large amount of common syntax, which I believe has priority over speed since the library is not _that_ slow at this time. Makes sense. I can start filing issues for the bugs that I have found through the rewrite, to help towards this. > Once that is done, my tentative idea is to refactor and switch to a much more Rusty trait-driven system such as the one we use in [diesel](https://github.com/diesel-rs/diesel) for the backends. I suggest as you proposed to open a [discussion](https://github.com/apache/datafusion-sqlparser-rs/discussions) where to put down the details of the matters and in particular how to deal with the many corner cases which make trivial approaches non generalizable. We can't really use GitHub discussions because they aren't reflected on the mailing list, so I think it would be best to discuss on this issue for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
