LucaCappelletti94 commented on issue #2893:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6745155036
> I'm still working towards 100% support for all the features of v1 and
full parity with the test corpus. I also wanted to gauge interest in a rewrite
first, before sharing the implementation.
Definitely lots of interest on my part, as at this time the code is
basically structure-less, filled with unnecessary allocations and evidently
much slower than its best possible version. I made [that
benchmark](https://sql-ast-benchmark.luca.phd/) exactly to keep track of how
this and other libraries performs across various axes. I would love to see a
discontinuity on perfs there.
> Makes sense. I can start filing issues for the bugs that I have found
through the rewrite, to help towards this.
Do open a dedicated issue if they are major, otherwise if they are minor
fuzzer-like bugs do put them in a comment of your own in
https://github.com/apache/datafusion-sqlparser-rs/issues/2840 so we can keep
track of them in a single place. There are certainly several bug categories,
especially regarding the tokenizer, that can only be addressed fully and
efficiently with a per-dialect tokenizer.
> We can't really use GitHub discussions because they aren't reflected on
the mailing list, so I think it would be best to discuss on this issue for now.
I wasn't aware of this, good to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
