EmilyMatt commented on code in PR #27302:
URL: https://github.com/apache/datafusion/pull/27302#discussion_r4525816644
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -556,69 +589,29 @@ impl PhysicalExpr for BinaryExpr {
let lhs = self.left.evaluate(batch)?;
// Check if we can apply short-circuit evaluation.
- match check_short_circuit(&lhs, &self.op) {
+ match check_short_circuit(&lhs, &self.op, ||
self.children_volatility().right) {
Review Comment:
just init the oncelock don't pass a closure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
