EmilyMatt commented on code in PR #27302:
URL: https://github.com/apache/datafusion/pull/27302#discussion_r4525885365
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1194,6 +1189,71 @@ impl BinaryExpr {
}
}
+ /// Evaluates the RHS of `OR` only on the rows selected by `mask` (the rows
+ /// whose result depends on the RHS); the other rows are `fill_value`.
+ fn evaluate_pre_selection(
+ &self,
+ batch: &RecordBatch,
+ lhs: ColumnarValue,
+ mask: &BooleanArray,
+ fill_value: bool,
Review Comment:
e.g., to make true_count() or false_count() more likely to be uniform?
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1194,6 +1189,71 @@ impl BinaryExpr {
}
}
+ /// Evaluates the RHS of `OR` only on the rows selected by `mask` (the rows
+ /// whose result depends on the RHS); the other rows are `fill_value`.
+ fn evaluate_pre_selection(
+ &self,
+ batch: &RecordBatch,
+ lhs: ColumnarValue,
+ mask: &BooleanArray,
+ fill_value: bool,
Review Comment:
why is a fill_value needed? it can just be Default, a.k.a false? is this for
some optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
