alexanderbianchi commented on code in PR #67:
URL: https://github.com/apache/datafusion-iceberg/pull/67#discussion_r4577170744


##########
crates/datafusion/src/read/scan.rs:
##########
@@ -145,32 +216,128 @@ impl IcebergDataSourceBuilder {
         self
     }
 
+    /// Finish configuring the scan and optionally select its files before 
execution.
+    ///
+    /// Honors [`IcebergPlanningConfig::eager_file_planning`]. The returned 
builder
+    /// only exposes `build`, so filters, projection, and snapshot cannot 
change
+    /// after files have been selected.
+    ///
+    /// # Errors
+    ///
+    /// Returns an error if the projection is invalid, file planning fails, or
+    /// the retained tasks exceed the query memory pool.
+    pub async fn with_planned_files(
+        self,
+        context: Arc<TaskContext>,
+    ) -> Result<PlannedIcebergDataSourceBuilder> {
+        if !context

Review Comment:
   Changed from the older iteration to match your proposed 
`with_planned_files(&self, groups: Vec<Vec<FileScanTask>>)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to