alexanderbianchi commented on code in PR #67:
URL: https://github.com/apache/datafusion-iceberg/pull/67#discussion_r4577205967
##########
crates/datafusion/src/read/scan.rs:
##########
@@ -231,11 +424,18 @@ impl DataSource for IcebergDataSource {
if let Some(fetch) = self.fetch {
write!(f, ", fetch={fetch}")?;
}
+ if let Some(planned) = self.planned_files() {
+ write!(f, ", planned_files={}", planned.tasks().len())?;
+ }
Ok(())
}
fn output_partitioning(&self) -> Partitioning {
- Partitioning::UnknownPartitioning(1)
+ Partitioning::UnknownPartitioning(
+ self.planned
+ .as_ref()
+ .map_or(1, |planned| planned.partitions),
+ )
}
Review Comment:
https://github.com/apache/datafusion-iceberg/issues/84 issue is here, and
there are examples of doing this in DFD. To remove the DFD data source provider
we should do it here anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]