andygrove commented on PR #7027:
URL: 
https://github.com/apache/datafusion-comet/pull/7027#issuecomment-6900619736

   Merged `main` in af5537102. Conflicts resolved as planned:
   
   - `IcebergWriteProtoTranslation`: kept this PR's `codecName` (no trim, no 
lowercase), and `compressesWithBrotli` is now 
`nativeCodec(codecName(props)).contains(CompressionCodec.Brotli)`, with its 
Scaladoc updated. The brotli detection test now asserts that `" brotli "` is 
not detected, since iceberg-java does not trim either and the codec gate 
declines that write first.
   - `CometIcebergNativeWrite`: kept `requireNativeSupportedCompressionCodec` 
and dropped `requireShredVariantsDisabled`, which #7603 removed on `main`.
   - `iceberg.md`: the compression row keeps this PR's codec wording and 
`snappy/lz4/uncompressed`, plus #6996's `BrotliCodec` note. Under "Writes that 
differ from Spark", both entries are resolved (brotli by #6996, `none` by this 
PR), so the section now says no known native write differs.
   
   `IcebergWriteProtoTranslationSuite` and `CometIcebergWriteDetectionSuite` 
pass locally (116 tests).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to