sunchao commented on code in PR #7540:
URL: https://github.com/apache/datafusion-comet/pull/7540#discussion_r4633321876


##########
.asf.yaml:
##########
@@ -42,23 +42,12 @@ github:
     issues: true
     discussions: true
     projects: true
+  # Release branches only. `main` is protected by the rulesets below instead:
+  # while classic protection exists on a branch, GitHub refuses a ruleset
+  # bypass on it, even for an approved PR with green checks
+  # (apache/iceberg-rust#3481). dev/ci/check-ci-config.py fails if `main`
+  # comes back here.
   protected_branches:

Review Comment:
   [P2] Install the replacement protection before removing the classic rule
   
   Could we split this into the two deployment steps mentioned in the 
description? I checked the ordering question in asfyaml: [the directive loop 
and import 
order](https://github.com/apache/infrastructure-asfyaml/blob/e4c2644ca10f37dd35bd11ce71d49d22546eb146/asfyaml/feature/github/__init__.py#L274-L301)
 run `branch_protection` before `rulesets`, and [the former immediately calls 
`remove_protection()`](https://github.com/apache/infrastructure-asfyaml/blob/e4c2644ca10f37dd35bd11ce71d49d22546eb146/asfyaml/feature/github/branch_protection.py#L294-L300)
 for omitted branches. Thus migrating from the current configured state deletes 
`main`'s review/check protection before the replacement ruleset is created. An 
intervening API or team-resolution failure aborts without restoring it. This 
confirms the risk already raised in the draft, rather than relying on the YAML 
section order. Please first add and verify `Default Branch Protection` and the 
queue's `Required Checks` rule while retaining cl
 assic protection, then remove the classic rule and enable the bypass in a 
second change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to